-
Notifications
You must be signed in to change notification settings - Fork 80
Use NetworkConfigurator #535
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Use NetworkConfigurator #535
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #535 +/- ##
=======================================
Coverage 94.81% 94.81%
=======================================
Files 31 31
Lines 1370 1370
=======================================
Hits 1299 1299
Misses 71 71 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
bd3fd1f
to
068496c
Compare
380e974
to
8047509
Compare
update test ci update example of sketch that uses the NetworkConfigurator use NetworkConfigurator wrappers for agentsManager
8c00c86
to
a2067ea
Compare
a2067ea
to
819161c
Compare
Memory usage change @ e749fc3
Click for full report table
Click for full report CSV
|
e749fc3
to
bbf3f69
Compare
Memory usage change @ bbf3f69
Click for full report table
Click for full report CSV
|
Memory usage change @ ab923bb
Click for full report table
Click for full report CSV
|
Memory usage change @ 370ef63
Click for full report table
Click for full report CSV
|
Memory usage change @ b7f0655
Click for full report table
Click for full report CSV
|
initProperties(); | ||
AgentsManagerClass::getInstance().begin(); | ||
LEDFeedbackClass::getInstance().begin(); | ||
DEBUG_INFO("Starting Provisioning"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would add also the binary version and Network configurator version
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The network configurator version is already inside the NetworkConfigurator with a specific command for read it and for the binary version I think we can keep aligned with the SKETCH_VERSION
Edit the ArduinoIoTCloudTCP FSM for using the NetworkConfigurator
void setConfigurator(NetworkConfiguratorClass & configurator)
void disconnect()